Conversation
- Add SystemCore::getShortCoreMask() to generate the old 32-bit CoreMask, if the CoreId < 32. - Deprecate SystemCore::Mask field, to be replaced by getShortCoreMask(). Reason for this is that SystemCores > 32 can't have short masks. - Add overload to createCoreVectorFromCoreMask that uses return value instead of out param.
…moving Mask field.
…ying on predefinied IdToSystemCore.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #2197 +/- ##
==========================================
+ Coverage 82.89% 82.92% +0.02%
==========================================
Files 336 336
Lines 61062 61214 +152
Branches 12965 12656 -309
==========================================
+ Hits 50620 50759 +139
+ Misses 9566 9088 -478
- Partials 876 1367 +491
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Dimi1010
commented
Jul 30, 2026
This reverts commit c47cdc9.
…PcapPlusPlus into feature/long-core-mask
Dimi1010
force-pushed
the
feature/long-core-mask
branch
from
September 16, 2026 10:51
36e0414 to
5b77d9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds infrastructure for extended core mask that allows addressing up to 256 machine cores.
Part of #1717
Proposal
Current server grade processors frequently exceed 32 cores. The current core mask implementation cannot address these cores as it is limited to 32 bits. The PR proposes adding a new mask object
LongCoreMaskthat is based onstd::bitmaskinstead ofuint32_tthat can accommodate up to 256 machine cores. The maximum of 256 was chosen as it is the highest available count that would not require changingSystemCore::CoreIddata type fromuint8_ttouint16_t. Further expansion can happen in a future PR.Changes
LongCoreMaskto support larger machine core count.SystemCore::Maskhas been deprecated to disambiguate between the short and long core masks. The field would also be unsafe for system cores with IDs over 32, as they can't be represented. It has been replaced bySystemCore::getShortCoreMask()which dynamically computes the mask from the currentSystemCore::CoreId.createCoreVectorFromCoreMaskwhich uses return value instead of out parameter.createCoreMaskFromCoreVectorandcreateCoreMaskFromCoreIds. They will now throwstd::out_of_rangeexception if they encounterCoreId >= 32.@briefdid not have their documentation added as short documentation.Not planned in this PR
LongCoreMaskinPfRingDevice.LongCoreMaskinDpdkDevice.